Forum Replies Created
Viewing 13 posts - 1 through 13 (of 13 total)
-
AuthorPosts
-
portalZINESpectatorSame problem on my test setup. The course admin is not loading. WPLMS + Modern Theme + all the latest updates. /course/software-training/admin sends a 404 /course/software-training/?action=admin works BTW works perfectly on 1.9.9.1 without the permalink changes. To restore on WPLMS 2.0 go to LMS->Settings-> activate -> Revert pretty permalinks for Courses Regards AlexportalZINESpectatorI know, but its not the only thing breaking right now :)portalZINESpectatorWPLMS should offer an auto downgrade option! Already moving the 2nd website back to 1.9.9. for a client, as they decided to do the upgrade blindly themselves ... Looking forward to the 2.0.2 update, but will not move any website to 2.0x in the coming week until things start working on my test environment again. All that fun just before the weekend starts, some long painful days ahead ... AlexportalZINESpectatorOk ... AlexportalZINESpectator$enable = get_user_meta($user_id,'instructor_start_assignment',true); if($enable !== 'no'){ So if touch points have been disabled for instructors through the touch point admin , as you proposed, this will always lead to emails being send to the instructor. They can no longer disable them, so meta value will never be "NO" No other check for the global admin touch points setting, it goes directly to bp_course_wp_mail. So what the system needs to do, is prevent emails to be send if touch points are disabled for a specific action. You take control away from the user. so the enable function should check both, something like that: $enable = get_user_meta($user_id,'instructor_start_assignment',true); if($enable !== 'no' && $global_touch_point_check['instructorStartAssignment']['email'] == true ){ AlexportalZINESpectatorFunction with missing $to is: function instructor_email_start_assignment($assignment_id,$user_id){ AlexportalZINESpectator1. The above 15 functions are not checking if the instructor allows emails to be send. So touch point settings are never applied. Missing enabled check or are not available within the touch point setup yet! 2. You are right about the above pasted code, pasted the wrong function :), but the $to is missing in one of these. We are running the latest version! AlexportalZINESpectatorMissing email / message opt-out for: 1. function instructor_email_quiz_submit($quiz_id,$user_id){ 2. function instructor_email_quiz_retake($quiz_id,$user_id){ 3. function instructor_email_quiz_reset($quiz_id,$user_id){ 4. function instructor_email_assignment_submit($assignment_id,$user_id) 5. function instructor_email_assignment_reset($quiz_id,$user_id){ 6. function instructor_email_course_subscribed($course_id,$user_id,$group_id = null){ 7. function instructor_email_course_added($check_action,$course_id,$members){ 8. function instructor_email_course_start($course_id,$user_id){ 9. function instructor_email_course_submit($course_id,$user_id){ 10. function instructor_email_course_reset($course_id,$user_id){ 11. function instructor_email_course_retake($course_id,$user_id){ 12. function instructor_email_course_evaluation($course_id,$marks,$user_id){ 13. function instructor_email_course_badge($course_id,$badges,$user_id,$badge_filter){ 14. function instructor_email_course_certificate($course_id,$pass,$user_id,$passing_filter){ 15. function instructor_email_course_review($course_id,$rating,$title){ All instructor emails should be opt-in. You are spamming users. Thanks AlexportalZINESpectatorAnd while I am evaluating and going over all the code, is there any plan to revamp the assignments really soon, as this will decide the fate of the system for many customers. It is one of the key features, that sets WPLMS apart, but interface and functionality still has many holes. Your competitors are closing in fast :) Thanks AlexportalZINESpectatorI am also guessing that once you disabled the notifications through the admin, the settings for emails are no longer available in the BuddyPress profile email settings section. As the often used flag "no" for email notifications will never be true, emails will continue to be send out! So if an instructor saved his email settings before the admin disabled the settings, there might still be a "yes" flag in there. This whole setup is far from optimal. Are you checking the admin settings before sending out the emails ??? Thanks AlexportalZINESpectatorTrying to track down the error myself. Already found one problem: bp-course-notifications.php :1592 - missing $to
BTW CODE display is broken in here :) Alexfunction instructor_email_assignment_evaluation($assignment_id,$marks,$user_id,$max){ $enable = get_user_meta($user_id,'instructor_assignment_evaluation',true); if($enable !== 'no'){ $to=get_post_field('post_author', $assignment_id); $subject = sprintf(__('Assignment %s evaluated for Student','vibe'),get_the_title($assignment_id)); $message = sprintf(__('Student %s got %s from %s in assignment %s ','vibe'),bp_core_get_userlink($user_id),$marks,$max,get_the_title($assignment_id)); if(count($to)) bp_course_wp_mail($to,$subject,$message,array('instructor_email_assignment_evaluation','item_id'=>$assignment_id,'user_id'=>$user_id,'marks'=>$marks,'maximum'=>$max)); } }
portalZINESpectatorThis is not helping, as the instructors are still getting multiple emails per assignment. The admin settings are disabled in the admin and the instructor has disabled her settings. So something else is wrong. Please take a closer look at this. AlexportalZINESpectatorHad to move the defines to the wp-config : # SLUGS if ( ! defined( 'WPLMS_COURSE_SLUG' ) ) define( 'WPLMS_COURSE_SLUG', 'lesson' ); if ( ! defined( 'BP_COURSE_SLUG' ) ) define( 'BP_COURSE_SLUG', 'lesson' ); if ( ! defined( 'BP_COURSE_INSTRUCTOR_SLUG' ) ) define( 'BP_COURSE_INSTRUCTOR_SLUG', 'teacher-lessons'); Not ideal, but works for now :) Regards Alex -
AuthorPosts
Viewing 13 posts - 1 through 13 (of 13 total)