Assignment notifications

[Stefan]

After assignments submissions the instructors still get notifications. Even when in the account settings al the notifications are turned off. I get a lot of angry complaints about this. Please solve this   Thanks

[Anshuman Sahu]

Please disable the assignment submit notifications from wp-admin ->LMs ->settings ->touch points : http://prntscr.com/8rhnq6

[portalZINE]

This is not helping, as the instructors are still getting multiple emails per assignment. The admin settings are disabled in the admin and the instructor has disabled her settings. So something else is wrong. Please take a closer look at this. Alex

[portalZINE]

Trying to track down the error myself. Already found one problem: bp-course-notifications.php :1592 - missing $to

function instructor_email_assignment_evaluation($assignment_id,$marks,$user_id,$max){	
		$enable = get_user_meta($user_id,'instructor_assignment_evaluation',true);
		if($enable !== 'no'){
			$to=get_post_field('post_author', $assignment_id);
			$subject = sprintf(__('Assignment %s evaluated for Student','vibe'),get_the_title($assignment_id));
			$message = sprintf(__('Student %s got %s from %s in assignment %s ','vibe'),bp_core_get_userlink($user_id),$marks,$max,get_the_title($assignment_id));

			if(count($to))			
				bp_course_wp_mail($to,$subject,$message,array('instructor_email_assignment_evaluation','item_id'=>$assignment_id,'user_id'=>$user_id,'marks'=>$marks,'maximum'=>$max));	
		}
	}

BTW CODE display is broken in here :) Alex

[portalZINE]

I am also guessing that once you disabled the notifications through the admin, the settings for emails are no longer available in the BuddyPress profile email settings section. As the often used flag "no" for email notifications will never be true, emails will continue to be send out! So if an instructor saved his email settings before the admin disabled the settings, there might still be a "yes" flag in there. This whole setup is far from optimal. Are you checking the admin settings before sending out the emails ??? Thanks Alex

[portalZINE]

And while I am evaluating and going over all the code, is there any plan to revamp the assignments really soon, as this will decide the fate of the system for many customers. It is one of the key features, that sets WPLMS apart, but interface and functionality still has many holes. Your competitors are closing in fast :) Thanks Alex

[portalZINE]

Missing email / message opt-out for: 1. function instructor_email_quiz_submit($quiz_id,$user_id){ 2. function instructor_email_quiz_retake($quiz_id,$user_id){ 3. function instructor_email_quiz_reset($quiz_id,$user_id){ 4. function instructor_email_assignment_submit($assignment_id,$user_id) 5. function instructor_email_assignment_reset($quiz_id,$user_id){ 6. function instructor_email_course_subscribed($course_id,$user_id,$group_id = null){ 7. function instructor_email_course_added($check_action,$course_id,$members){ 8. function instructor_email_course_start($course_id,$user_id){ 9. function instructor_email_course_submit($course_id,$user_id){ 10. function instructor_email_course_reset($course_id,$user_id){ 11. function instructor_email_course_retake($course_id,$user_id){ 12. function instructor_email_course_evaluation($course_id,$marks,$user_id){ 13. function instructor_email_course_badge($course_id,$badges,$user_id,$badge_filter){ 14. function instructor_email_course_certificate($course_id,$pass,$user_id,$passing_filter){ 15. function instructor_email_course_review($course_id,$rating,$title){ All instructor emails should be opt-in. You are spamming users. Thanks Alex

[MrVibe]

Ok, let me clarify how the touch points work : a. The Touch points options are stored in LMS options in options table. b. To execute the touch points, we "first" fetch the saved information (enabled touch points). Each of these touch points have information about the "wplms action hook", at which we need to send the message, notification or email. c. The saved touch points emails appear in Profile - Settings - email of every user, where every user can configure if she wants to receive the email, the default is "yes" d. Then we run the loop to execute  the saved touch points. e. For emails we check the saved touch point setting before sending the email. So, everything works from saving of touch points, if the touch points are not saved, none of the touch points work. Thanks for digging in , but I am unable to locate the reported bug (screenshot : http://prntscr.com/8z7s5g), please make sure Vibe Course module is updated to latest module. Let me know if I missed something. Lastly, for sending emails, you need to enable html_emails setting and save the Email template in LMS - Settings - Emails and also save the email template.  

[portalZINE]

1. The above 15 functions are not checking if the instructor allows emails to be send. So touch point settings are never applied. Missing enabled check or are not available within the touch point setup yet! 2. You are right about the above pasted code, pasted the wrong function :), but the $to is missing in one of these. We are running the latest version! Alex

[portalZINE]

Function with missing $to is: function instructor_email_start_assignment($assignment_id,$user_id){ Alex

[portalZINE]

$enable = get_user_meta($user_id,'instructor_start_assignment',true); if($enable !== 'no'){ So if touch points have been disabled for instructors through the touch point admin , as you proposed, this will always lead to emails being send to the instructor. They can no longer disable them, so meta value will never be "NO" No other check for the global admin touch points setting, it goes directly to bp_course_wp_mail. So what the system needs to do, is prevent emails to be send if touch points are disabled for a specific action. You take control away from the user. so the enable function should check both, something like that: $enable = get_user_meta($user_id,'instructor_start_assignment',true); if($enable !== 'no' && $global_touch_point_check['instructorStartAssignment']['email'] == true ){ Alex

[Anshuman Sahu]

I think you've misunderstood how this works. Function : instructor_email_start_assignment($assignment_id,$user_id) does not require $to , because we get the instructor id from assignment id.  Here is once again how this works : a. Enable touch points work, so Emails are only sent out for enabled touch points. b. Then just before sending the email we check the user setting. Default is yes. So, what you're suggesting is not valid because the function responsive for sending email does not run when the touch point is not enabled.    

[Anshuman Sahu]

We have resolved the many issues with the touch points in the recent update of vibe course module plugin  .

[portalZINE]

Ok ... Alex

[Author]

Posts