Visual Composer, Vibe CustomTypes and AutoP

[Ravi Kiran Katha]

I am facing an issue with the tinymce editors inside the visual composer widgets/containers. The normal editors like the main page/post content work fine as intended.

1. The text mode does not show quicktag buttons
2. The wpautop = false setting in my TinyMCE Config is not used anywhere inside the editor. Because of this, unwanted p & br tags are being inserted in the content even while editing/saving in the text mode.

After a little bit of troubleshooting, I had to make some changes in the file \wp-content\plugins\vibe-customtypes\metaboxes\library\js\v_admin.js I have taken the version 2.0.9.1 of the plugin and modified the v_admin.js file. Attached is the modified file. @Author(s) - Please review the differences between the original 2.0.9.1 file and the attached one and merge the required changes into the mainline, so that they will be available in the next update. Let me know if you need any clarifications or questions about my website setup.

[Anshuman Sahu]

Thanks for the file. We will review and make the changes accordingly. We'll add the quicktags init line in the editor re-init. p.s : The Auto-P is a necessary WordPress function and may not be removed as it is crucial for theme's design and content display. Also, if the issue originally exists in Visual composer then we would like to contact Visual composer and get some suggestions from their dev team on this as well.

[Ravi Kiran Katha]

With AutoP, if enter something in the text mode of the editor - for e.g. [one_third][/one_third] [two_third][/two_third] each line is wrapped with p tag and also br tags are inserted in between the content, which breaks the layout. Since autop is an optional thing, it is to be left to the choice of the developer whether to use it or not. In fact I can enable/disable that option per page basis using WP Editor plugin. So if I want it to be off, I should be able to do it.

[Anshuman Sahu]

Well for this to encounter you have to add shortcodes on text mode for that . You can create a feature request for this here : https://wplms.io/support/forums/forum/general/feature-request/ If upvoted we will add this in the upcoming updates of wplms .

[Ravi Kiran Katha]

I think this should be a bug rather than a new feature. The visual composer plugin/vibe customtypes plugins [inhibit the default functionality]. The shortcodes within the default post or page bodies do not have this issue when editing in text mode. The issue is only with the text mode editing inside the visual composer

[MrVibe]

No, this is not a bug. We want the default p tags for proper indentation of text in default posts and content areas. You may be correct in identifying this but we assume Visual Composer is a complete plugin and it does not require any changes, so we're not going to add any changes specifically for Visual composer plugin, this is also based on the fact that we do not get any support from Visual composer (many of our support tickets in visual composer are pending from January/February'16), if you do a simple search half of the topics created in our support forums are because  of vc and since we can not modify the code, we're usually stuck on such issues. So we do not want to add/remove anything form the VC plugin. If you feel we should add this then we need more users to vote/discuss on this as a lot of users use Visual composer and it could impact them. As of now this is the only request for this. Please create a support topic in the feature requests section. As an alternative maybe we can share a quick fix specifically for such issues. So users who need it can add them in their sites. Let me know if this suggestion works for you.

[Ravi Kiran Katha]

I get what you say. It is not advisable to change an external plugin - in case of any updates, we loose the changes. If you check the fix I submitted, it is in coursetypes plugin. The fix is not in visual composer plugin. The coursetypes module hooks into the editor creation inside visual composer layout. The fix I submitted only ensures that, the configured tinymce settings are taken care as the first step in the hooking process. It is not just about wpautop. Most of the TinyMCE configuration set at the site level are not applied. If you compare the js file I attached with the original version, you will find that the changes are only minor and wont effect anything else in the coursetypes plugin. Alternatively, an option in the admin can be added to selectively include these changes. For e.g. "Enable TinyMCE configuration in Visual Composer Editors". When checked, the code fixes come into play otherwise not. Regarding your suggestion of adding it to the tips section, myself/users still need to apply that fix - every time a new version of coursetypes is released. My intention is to include the fix inside the plugin, so that I or other users do not have to carry on the fix across plugin updates. Regarding creating a feature for voting, if it is a minor fix (few lines in js without affecting any other functionality) - I guess it is a waste of effort & time. But still, if that is the only way - I can do that. Let me know your decision on that.

[MrVibe]

I think we can go with this :  an option in the admin can be added to selectively include these changes. For e.g. "Enable TinyMCE configuration in Visual Composer Editors". When checked, the code fixes come into play otherwise not.

[Ravi Kiran Katha]

Thanks. Will be waiting for it to be implemented.

[H.K. Latiyan]

This has been added in the latest update of wplms 2.1, so please update the wplms theme and all its plugins to latest version i.e. 2.1 and then check.

[Author]

Posts