Bug in footer filter for logo

[Makarand Mane]

Hi Mr. Vibe I want to remove logo from footer, So removed it from options. But after that it is printing url of Logo only, see screenshot. https://prnt.sc/sngywt I found code mistake, which I have highlighted in screenshot. Did u echo with some purpose or its coding mistake from your side.

function vibe_logo_url

[Veronica]

hi, this for those users who have no idea that where the logo is placed in case if logo is not showing in the footer due to some error then it shows the url of it. you can simply use this: https://wplms.io/support/knowledge-base/how-to-remove-footer-logo/

[Makarand Mane]

Hi Veronica, That idiotic way I feel. Why to keep unwanted HTML in output. If I don't want logo in footer then it should removed from options only. Unwanted HTML & unwanted CSS, how it will optimize performance of website. Isn't it unwanted load on DOM?

[Anshuman Sahu]

Yes you are we should return 0 from there. I dont know why we put there its because we are following same pattern in all other cases of header logos to handle when header logos are not set . Made the suggested change thanks for reporting .

[Makarand Mane]

Hi Alex I will recommend you then use button switch with three option then,

1. Same as header
2. upload new
3. disable

see http://prnt.sc/spfcen

[Anshuman Sahu]

Thanks for the suggestion . We will try to implement this right now we have returned 0 ther e.

[Author]

Posts